[PATCH] D48247: lld: add experimental support for SHT_RELR sections.

[Rahul Chaudhry via Phabricator via llvm-commits]

rahulchaudhry marked an inline comment as done.
rahulchaudhry added inline comments.


================
Comment at: ELF/Driver.cpp:953
+  // relocations decode to offsets only.
   Config->WriteAddends = Args.hasFlag(OPT_apply_dynamic_relocs,
                                       OPT_no_apply_dynamic_relocs, false) ||
----------------
mcgrathr wrote:
> It doesn't seem right to start writing nonzero values into the section data on RELA machines for all relocs.
> The addend should only be written in place for words actually converted to RELR slots.
Moved the logic to RelocationBaseSection::addReloc() where Config->WriteAddends is actually checked.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D48247