[PATCH] D48305: [IR] Introduce helpers to skip debug instructions (NFC)

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 19 11:14:03 PDT 2018


efriedma added inline comments.


================
Comment at: lib/IR/Instruction.cpp:602
+      return I;
+  return nullptr;
+}
----------------
Maybe this should assert rather than return nullptr?  It's probably a logic error if you're calling getNextNonDebugInstruction() on a terminator.


https://reviews.llvm.org/D48305





More information about the llvm-commits mailing list