[PATCH] D48079: [X86] Add sched class WriteLAHFSAHF and fix values.

Greg Bedwell via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 19 09:32:06 PDT 2018


gbedwell added inline comments.


================
Comment at: test/tools/llvm-mca/X86/BtVer2/partial-reg-update-2.s:1
+# NOTE: Assertions have been autogenerated by utils/update_mca_test_checks.py
 # RUN: llvm-mca -mtriple=x86_64-unknown-unknown -mcpu=btver2 -iterations=1 -resource-pressure=false -timeline < %s | FileCheck %s
----------------
RKSimon wrote:
> gbedwell wrote:
> > RKSimon wrote:
> > > revert this? @gbedwell any idea why this got inserted?
> > Merely because I regenerated all tests using a wildcard.  It's regenerated the checks which happen to be identical to the previous manually inserted checks.  I can revert, but we should probably re-add this line in a separate commit just to reduce noise from wildcard regenerating tests.
> Something I didn't realise - Andrea's commit yesterday already added this line - @courbet if you rebase then this diff should just go away.....
Aha. I thought I was replying to a different review (hence why I wrote "I regenerated") as I have exactly the same diff in D48276 :)


Repository:
  rL LLVM

https://reviews.llvm.org/D48079





More information about the llvm-commits mailing list