[PATCH] D48223: Allow binop C1, (select cc, CF, CT) -> select folding

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 19 04:17:39 PDT 2018


arsenm added inline comments.


================
Comment at: test/CodeGen/AMDGPU/dagcombine-select.ll:1
+; RUN: llc -march=amdgcn -verify-machineinstrs < %s | FileCheck -enable-var-scope -check-prefix=GCN %s
+
----------------
Use an i16 target for i16 tests


================
Comment at: test/CodeGen/AMDGPU/dagcombine-select.ll:5
+; v_cndmask_b32_e64 v{{[0-9]+}}, 2, 9,
+define amdgpu_kernel void @sel_constants_sub_constant_sel_constants(i32 addrspace(1)* %p, i1 %cond) {
+  %sel = select i1 %cond, i32 -4, i32 3
----------------
Some tests with i16 would be useful (as well as vectors)


https://reviews.llvm.org/D48223





More information about the llvm-commits mailing list