[PATCH] D48230: [PredicateInfo] Order instructions in different BBs by DFSNumIn.

[Florian Hahn via Phabricator via llvm-commits]

fhahn updated this revision to Diff 151892.
fhahn added a comment.

I moved the logic to OrderedInstructions::comesBefore, because I think it makes sense there and has potential to be useful in other places too. I've also added a test case where the collected values are visited in non-deterministic order without this patch and added a debug line to easily check the order.

If that is not desirable, I think I could come up with a larger test case, which also exposes the problem, but might not fail as reliable without this patch.


https://reviews.llvm.org/D48230

Files:
  include/llvm/Transforms/Utils/OrderedInstructions.h
  lib/Transforms/Utils/OrderedInstructions.cpp
  lib/Transforms/Utils/PredicateInfo.cpp
  test/Transforms/Util/PredicateInfo/ordering.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D48230.151892.patch
Type: text/x-patch
Size: 6824 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180619/310fe78e/attachment.bin>