[PATCH] D25622: [mips] Check that emitted instructions meet their predicates on Mips

[Simon Dardis via Phabricator via llvm-commits]

sdardis added subscribers: atanasyan, llvm-commits, abeserminji, smaksimovic.
sdardis added a comment.
Herald added a subscriber: arichardson.

Looking at this again and with trunk, I'm seeing two failing tests with a small change inlined:

Failing Tests (2):

  LLVM :: MC/Mips/expansion-jal-sym-pic.s
  LLVM :: MC/Mips/micromips32r6/valid.s



================
Comment at: lib/Target/Mips/MCTargetDesc/MipsMCCodeEmitter.cpp:189-190
 {
+  verifyInstructionPredicates(MI,
+                              ComputeAvailableFeatures(STI.getFeatureBits()));
 
----------------
This is in the wrong place. It should be:


================
Comment at: lib/Target/Mips/MCTargetDesc/MipsMCCodeEmitter.cpp:259
   }
 
   const MCInstrDesc &Desc = MCII.get(TmpInst.getOpcode());
----------------
Here. Moving this here means that we translate the instructions to the correct form, then verify it.


https://reviews.llvm.org/D25622