[PATCH] D48279: [PatternMatch] Add m_Store pattern match helper
Dave Green via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 19 04:55:15 PDT 2018
dmgreen added inline comments.
================
Comment at: unittests/IR/PatternMatch.cpp:403
+ Value *StoreInst = IRB.CreateStore(IRB.getInt32(42), Alloca);
+ Value *MatchLoad, *MatchStoreVal, *MatchStorePointer;
+
----------------
Can you remove these, just using m_Value() as the above tests? Or maybe better to test that they are the correct values (i.e EXPECT_EQ(Alloca, MatchStorePointer);)
https://reviews.llvm.org/D48279
More information about the llvm-commits
mailing list