[PATCH] D48210: [llvm-exegesis] A mechanism to add target-specific functionality.

[Clement Courbet via Phabricator via llvm-commits]

courbet added inline comments.


================
Comment at: tools/llvm-exegesis/lib/Uops.cpp:87
 
-// FIXME: Handle memory, see PR36905.
 static bool hasMemoryOperand(const llvm::MCOperandInfo &OpInfo) {
----------------
gchatelet wrote:
> Is the code to generate the memory Operands in?
Thanks for the catch, I did not want to submit this.


================
Comment at: tools/llvm-exegesis/llvm-exegesis.cpp:122
   llvm::InitializeNativeTargetAsmPrinter();
+#ifdef LLVM_EXEGESIS_INITIALIZE_NATIVE_TARGET
+  LLVM_EXEGESIS_INITIALIZE_NATIVE_TARGET();
----------------
gchatelet wrote:
> You shouldn't need the guard.
It's needed in case the target is not supported or not built for.


Repository:
  rL LLVM

https://reviews.llvm.org/D48210