[PATCH] D48210: [llvm-exegesis] A mechanism to add target-specific functionality.

[Guillaume Chatelet via Phabricator via llvm-commits]

gchatelet added inline comments.


================
Comment at: tools/llvm-exegesis/lib/Target.cpp:30
+  }
+  assert(Target->Next == nullptr && "multiple registration");
+  if (Target->Next != nullptr)
----------------
"Target has already been registered"


================
Comment at: tools/llvm-exegesis/lib/Uops.cpp:87
 
-// FIXME: Handle memory, see PR36905.
 static bool hasMemoryOperand(const llvm::MCOperandInfo &OpInfo) {
----------------
Is the code to generate the memory Operands in?


================
Comment at: tools/llvm-exegesis/llvm-exegesis.cpp:122
   llvm::InitializeNativeTargetAsmPrinter();
+#ifdef LLVM_EXEGESIS_INITIALIZE_NATIVE_TARGET
+  LLVM_EXEGESIS_INITIALIZE_NATIVE_TARGET();
----------------
You shouldn't need the guard.


================
Comment at: unittests/tools/llvm-exegesis/X86/TargetTest.cpp:21
+TEST_F(X86TargetTest, Lookup) {
+  EXPECT_NE(ExegesisTarget::lookup("x86_64-unknown-linux"), nullptr);
+}
----------------
EXPECT_THAT(..., NotNull()) ?


Repository:
  rL LLVM

https://reviews.llvm.org/D48210