[PATCH] D48247: lld: add experimental support for SHT_RELR sections.

Roland McGrath via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 18 15:29:28 PDT 2018


mcgrathr added inline comments.


================
Comment at: ELF/Driver.cpp:953
+  // relocations decode to offsets only.
   Config->WriteAddends = Args.hasFlag(OPT_apply_dynamic_relocs,
                                       OPT_no_apply_dynamic_relocs, false) ||
----------------
It doesn't seem right to start writing nonzero values into the section data on RELA machines for all relocs.
The addend should only be written in place for words actually converted to RELR slots.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D48247





More information about the llvm-commits mailing list