[PATCH] D48262: [WebAssembly] Add more utility functions

[Derek Schuff via Phabricator via llvm-commits]

dschuff added inline comments.


================
Comment at: lib/Target/WebAssembly/WebAssemblyUtilities.cpp:123
+  case WebAssembly::CALL_INDIRECT_VOID:
+    CalleeOpNo = 0;
+    break;
----------------
How about just `return 0` here and `return 1` below, with an unreachable as the default?


================
Comment at: lib/Target/WebAssembly/WebAssemblyUtilities.h:44
+/// Returns if the given BB is a single BB terminate pad which starts with a
+/// 'catch' insrtruction.
+bool isCatchTerminatePad(const MachineBasicBlock &MBB);
----------------
typo: 'instruction' and line 47


================
Comment at: lib/Target/WebAssembly/WebAssemblyUtilities.h:58
+/// Return the "bottom" block of an entity, which can be either a loop or an
+/// exception, or something else. This differs from
+/// MachineLoop::getBottomBlock in that it works even if the entity is
----------------
by 'exception' do you mean try block, catch block, both? what can 'something else' be?


Repository:
  rL LLVM

https://reviews.llvm.org/D48262