[PATCH] D47735: [DAGCombiner] Create rotates more aggressively

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 18 12:31:10 PDT 2018


RKSimon added inline comments.


================
Comment at: test/CodeGen/X86/rotate-multi.ll:1
+; RUN: llc -march=x86-64 < %s | FileCheck %s
+
----------------
kparzysz wrote:
> lebedev.ri wrote:
> > X86(and most others) tests mostly use `utils/update_llc_test_checks.py`
> The output looks worse: it checks almost every instruction and has specific register names (outside of argument registers).
But its much less likely to allow mistakes to get through. Plus on x86 its often very useful to check all the surrounding code as that often hides issues.

Once the test file is finalised best practice is to use update_llc_test_checks on it against trunk, commit that and then update the patch to show the codegen diff. 

Also, your RUN line should use a triple, not an arch.



Repository:
  rL LLVM

https://reviews.llvm.org/D47735





More information about the llvm-commits mailing list