[PATCH] D47735: [DAGCombiner] Create rotates more aggressively
Krzysztof Parzyszek via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 18 10:45:53 PDT 2018
kparzysz marked an inline comment as done.
kparzysz added a comment.
This patch and the one you mentioned coincidentally both apply to rotates, but there wasn't any coordination between them.
================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:4893
+ SmallVector<SDValue,8> OredOps;
+ std::queue<SDValue> WorkQ;
+ WorkQ.push(Op0);
----------------
lebedev.ri wrote:
> You can do
> ```
> std::queue<SDValue, SmallVector<SDValue, 8>> WorkQ;
> ```
> to get the usual small-size-optimization benefits.
SmallVector doesn't have pop_front, so that won't work.
Repository:
rL LLVM
https://reviews.llvm.org/D47735
More information about the llvm-commits
mailing list