[PATCH] D48229: [NFC][SCEV] Add tests related to bit masking (PR37793)

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added inline comments.


================
Comment at: lib/Transforms/InstCombine/InstCombineShifts.cpp:625-629
-    // Be careful about hiding shl instructions behind bit masks. They are used
-    // to represent multiplies by a constant, and it is important that simple
-    // arithmetic expressions are still recognizable by scalar evolution.
-    // The inexact versions are deferred to DAGCombine, so we don't hide shl
-    // behind a bit mask.
----------------
lebedev.ri wrote:
> spatel wrote:
> > Better to just add a 'FIXME' note until we actually make the code change here to ignore 'exact'?
> Yes, indeed. Will add.
Hopefully this is better.


Repository:
  rL LLVM

https://reviews.llvm.org/D48229