[PATCH] D48264: [MCA][NFC] Add generic XOP resource tests

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 18 10:24:06 PDT 2018


lebedev.ri added inline comments.


================
Comment at: test/tools/llvm-mca/X86/Generic/resources-xop.s:385
+
+# FIXME: i'm not certain that is what the docs meant re %xmm8
+vprotb %xmm8, %xmm0, %xmm3
----------------
RKSimon wrote:
> lebedev.ri wrote:
> > RKSimon wrote:
> > > I don't understand this comment?
> > The same doc/page i linked in the \/ next comment.
> > It lists three patterns:
> > ```
> > VPROTB xmm1, xmm2/mem128, xmm8 <- does this simply imply the %xmm8 register, which is only available in 64-bit more?
> > VPROTB xmm1, xmm2, xmm3/mem128
> > VPROTB xmm1, xmm2/mem128, imm8
> > ```
> > 
> Nope that is a classic AMD docs team copy+paste typo from copying the imm8 version :-)  It takes any xmm[0-7]/xmm[0-15] on 32/64
Ok, thank you, that makes more sense, and resolves these fixme's :)

So what was meant is:
```
VPROTB xmm1, xmm2, xmm3
VPROTB xmm1, mem128, xmm3
VPROTB xmm1, xmm2, mem128

VPROTB xmm1, xmm2, imm8
VPROTB xmm1, mem128, imm8
```
So just 5 tests.


Repository:
  rL LLVM

https://reviews.llvm.org/D48264





More information about the llvm-commits mailing list