[llvm] r334875 - [SCEV] Simplify some flags expressions.

Justin Lebar via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 15 16:52:11 PDT 2018


Author: jlebar
Date: Fri Jun 15 16:52:11 2018
New Revision: 334875

URL: http://llvm.org/viewvc/llvm-project?rev=334875&view=rev
Log:
[SCEV] Simplify some flags expressions.

Summary:
Sending for presubmit review out of an abundance of caution; it would be
bad to mess this up.

Reviewers: sanjoy

Subscribers: hiraditya, llvm-commits

Differential Revision: https://reviews.llvm.org/D48238

Modified:
    llvm/trunk/lib/Analysis/ScalarEvolution.cpp

Modified: llvm/trunk/lib/Analysis/ScalarEvolution.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Analysis/ScalarEvolution.cpp?rev=334875&r1=334874&r2=334875&view=diff
==============================================================================
--- llvm/trunk/lib/Analysis/ScalarEvolution.cpp (original)
+++ llvm/trunk/lib/Analysis/ScalarEvolution.cpp Fri Jun 15 16:52:11 2018
@@ -3897,7 +3897,7 @@ const SCEV *ScalarEvolution::getMinusSCE
   auto AddFlags = SCEV::FlagAnyWrap;
   const bool RHSIsNotMinSigned =
       !getSignedRangeMin(RHS).isMinSignedValue();
-  if ((Flags & SCEV::FlagNSW) == SCEV::FlagNSW) {
+  if (Flags & SCEV::FlagNSW) {
     // Let M be the minimum representable signed value. Then (-1)*RHS
     // signed-wraps if and only if RHS is M. That can happen even for
     // a NSW subtraction because e.g. (-1)*M signed-wraps even though
@@ -11940,7 +11940,7 @@ bool SCEVWrapPredicate::isAlwaysTrue() c
   SCEV::NoWrapFlags ScevFlags = AR->getNoWrapFlags();
   IncrementWrapFlags IFlags = Flags;
 
-  if ((ScevFlags | SCEV::FlagNSW) == ScevFlags)
+  if (ScevFlags & SCEV::FlagNSW)
     IFlags &= ~IncrementNSSW;
 
   return IFlags == IncrementAnyWrap;
@@ -11962,10 +11962,10 @@ SCEVWrapPredicate::getImpliedFlags(const
   SCEV::NoWrapFlags StaticFlags = AR->getNoWrapFlags();
 
   // We can safely transfer the NSW flag as NSSW.
-  if ((StaticFlags | SCEV::FlagNSW) == StaticFlags)
+  if (StaticFlags & SCEV::FlagNSW)
     ImpliedFlags = IncrementNSSW;
 
-  if ((StaticFlags | SCEV::FlagNUW) == StaticFlags) {
+  if (StaticFlags & SCEV::FlagNUW) {
     // If the increment is positive, the SCEV NUW flag will also imply the
     // WrapPredicate NUSW flag.
     if (const auto *Step = dyn_cast<SCEVConstant>(AR->getStepRecurrence(SE)))




More information about the llvm-commits mailing list