[PATCH] D47196: [Time-report ](2): Recursive timers in Clang

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

Can you give an example of what the output looks like?

Please don't define multiple different classes with the same name SortClassName.

It seems like you've scattered the "start" and "stop" calls all over the place; can you put the start and stop calls in the same place, somehow?



================
Comment at: lib/CodeGen/CodeGenAction.cpp:835
+    GlobalDecl GD;
+    return CGM.getMangledName(GD.getWithDecl(FD));
+  }
----------------
The use of getWithDecl here is weird; can you just do `GlobalDecl(FD)`?  If not, please add a comment explaining what you're doing.

Why does it matter whether the function has a body?  IIRC you should be able to mangle the name of functions without a body.


https://reviews.llvm.org/D47196