[PATCH] D45872: [DA] Enable -da-delinearize by default

[Brendon Cahoon via Phabricator via llvm-commits]

bcahoon added a comment.

Hi David,

We have a (loop) scalar replacement implementation that uses the dependence analysis information. We don't really need/use it much anymore for various reasons, including that there are other LLVM passes that get much of the same benefits.

You're correct about the problems with delinearizing. I think it was Sebastian who added a patch a while back that removed some of the delinearization code in DA that was incorrect (using the GEPs).  My example was a bad one, though. Sorry about that. I was trying to show an example where we could possibly delinearize correctly but still doesn't work with your patch.  I still think your patch is good as-is, and enabling the DA with delinearization is great, but I'm not sure if/what other opportunities it's still missing.

Thanks,
Brendon


https://reviews.llvm.org/D45872