[PATCH] D48229: [NFC][SCEV] Add tests related to bit masking (PR37793)

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 15 11:22:05 PDT 2018


lebedev.ri added inline comments.


================
Comment at: test/Analysis/ScalarEvolution/lshr-shl-differentconstmask.ll:44-45
+;
+  %tmp1 = lshr i32 %val, 6
+  %tmp2 = shl i32 %tmp1, 4
+  ret i32 %tmp2
----------------
@spatel BTW, how do we want to canonicalize it? https://rise4fun.com/Alive/mxm


================
Comment at: test/Analysis/ScalarEvolution/lshr-shl-differentconstmask.ll:72-73
+;
+  %tmp1 = lshr i32 %val, 4
+  %tmp2 = shl i32 %tmp1, 6
+  ret i32 %tmp2
----------------
Similarly, mask first or last? https://rise4fun.com/Alive/0X9


Repository:
  rL LLVM

https://reviews.llvm.org/D48229





More information about the llvm-commits mailing list