[PATCH] D48203: [SanitizerCoverage] Add associated metadata to pc-tables.
Evgenii Stepanov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 15 09:59:25 PDT 2018
eugenis added inline comments.
================
Comment at: llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp:409
appendToUsed(M, GlobalsToAppendToUsed);
+ appendToCompilerUsed(M, GlobalsToAppendToCompilerUsed);
+ }
----------------
morehouse wrote:
> eugenis wrote:
> > this is unnecessary, llvm.used is strictly stronger than llvm.compiler.used
> I'm not sure I understand... We're appending different things to each list.
Right. Sorry.
A different question then: why only MachO?
https://reviews.llvm.org/D48203
More information about the llvm-commits
mailing list