[PATCH] D47713: [AArch64][SVE] Asm: Support for INC/DEC (scalar) instructions.

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 15 07:14:45 PDT 2018


sdesmalen added inline comments.


================
Comment at: test/MC/AArch64/SVE/decb.s:118
+
+decb    x0, #14
+// CHECK-INST: decb    x0, #14
----------------
SjoerdMeijer wrote:
> I think you had a similar discussion with Florian about testing ranges of immediates in one of the other patches.
> Looks like your checking all values between:
> 
> decb x0, #14
> ...
> decb x0, #28
> 
> I certainly don't mind, but was just wondering if there's an added value (perhaps I am missing something).
Yes, that's a fair point, I can probably cut this down a bit by just testing the boundaries (#14 and #28) for most variants, and just let one variant (e.g. incb) test all of them. I'll make that change before I commit.


https://reviews.llvm.org/D47713





More information about the llvm-commits mailing list