[PATCH] D48209: [MCA] Add -summary-view option
Greg Bedwell via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 15 06:14:49 PDT 2018
gbedwell added a comment.
In https://reviews.llvm.org/D48209#1133500, @andreadb wrote:
> Given that Clement (and presumably Greg) are okay with this change, then I won't oppose it. Sorry for being pedantic.
I have no really strong opinion either way, but as it doesn't seem to affect the typical workflow I don't see any real reason to oppose. It's obviously odd to have a mode where the tool outputs nothing at all, but it's not like the user can easily run into that situation without explicitly requesting it. There is at least a nice consistency in having full customization control of all of the views. I guess there could be an argument to having something like "warning: no views are enabled" but I'm wary of getting too deep into the realms of bikeshedding over a minor change like this. :)
Repository:
rL LLVM
https://reviews.llvm.org/D48209
More information about the llvm-commits
mailing list