[PATCH] D48209: [MCA] Add -summary-view option

Andrea Di Biagio via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 15 05:51:06 PDT 2018


andreadb added a comment.

Given that Clement (and presumably Greg) are okay with this change, then I won't oppose it. Sorry for being pedantic.

See my comment below (as well as my comment from https://reviews.llvm.org/D48190)

Thanks
-Andrea



================
Comment at: tools/llvm-mca/llvm-mca.cpp:112-115
+static cl::opt<bool>
+    PrintSummaryView("summary-view",
+                     cl::desc("Print summary view (enabled by default)"),
+                     cl::cat(ViewOptions), cl::init(true));
----------------
Please mark this this option as "hidden". I don't think it should appear in the default -help output.


Repository:
  rL LLVM

https://reviews.llvm.org/D48209





More information about the llvm-commits mailing list