[PATCH] D47711: [AArch64][SVE] Asm: Add parsing/printing support for exact FP immediates.

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer accepted this revision.
SjoerdMeijer added a comment.
This revision is now accepted and ready to land.

Looks OK to me.



================
Comment at: lib/Target/AArch64/AArch64SystemOperands.td:240
+//===----------------------------------------------------------------------===//
+class ExactFPImm<string name, string repr, bits<4> enum > : SearchableTable {
+  let SearchableFields = ["Enum", "Repr"];
----------------
Nit: I think some comments how and why this is used (for SVE) would be good. I mean, "ExactFPImm" is kind of a generic name, but this is used a lookup table for a few instructions that only accept a few specific immediates.


================
Comment at: lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp:135
   OperandMatchResultTy tryParseAdrLabel(OperandVector &Operands);
+  template<bool Add00AsLiteral>
   OperandMatchResultTy tryParseFPImm(OperandVector &Operands);
----------------
Nit: perpahs a bit more descriptive name, e.g. AddFPZeroAsLiteral, or just AddZeroAsLiteral?


https://reviews.llvm.org/D47711