[PATCH] D48190: [MCA][x86][NFC] Add tests for -register-file-stats, -scheduler-stats

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: test/tools/llvm-mca/X86/register-file-statistics.s:4
+# RUN: llvm-mca %s -mtriple=x86_64-unknown-unknown -mcpu=znver1 -iterations=1 -register-file-stats -instruction-info=false -resource-pressure=false < %s | FileCheck --check-prefix=ALL --check-prefix=ZNVER1 %s
+# RUN: llvm-mca %s -mtriple=x86_64-unknown-unknown -mcpu=sandybridge -iterations=1 -register-file-stats -instruction-info=false -resource-pressure=false < %s | FileCheck --check-prefix=ALL --check-prefix=SANDYBRIDGE %s
+# RUN: llvm-mca %s -mtriple=x86_64-unknown-unknown -mcpu=ivybridge -iterations=1 -register-file-stats -instruction-info=false -resource-pressure=false < %s | FileCheck --check-prefix=ALL --check-prefix=IVYBRIDGE %s
----------------
Try to use shorter prefixes: SNB, IVB, HSW, BDW are the most common acronyms


================
Comment at: test/tools/llvm-mca/X86/register-file-statistics.s:11
+# RUN: llvm-mca %s -mtriple=x86_64-unknown-unknown -mcpu=skylake-avx512 -iterations=1 -register-file-stats -instruction-info=false -resource-pressure=false < %s | FileCheck --check-prefix=ALL --check-prefix=SKX-AVX512 %s
+# RUN: llvm-mca %s -mtriple=x86_64-unknown-unknown -mcpu=slm -iterations=1 -register-file-stats -instruction-info=false -resource-pressure=false < %s | FileCheck --check-prefix=ALL --check-prefix=SLM %s
+
----------------
Use --check-prefixes if you can, although I don't see any usage of ALL.


================
Comment at: test/tools/llvm-mca/X86/register-file-statistics.s:45
+# SKLSER-NEXT:    Total number of mappings created:    2
+# SKLSER-NEXT:    Max number of mappings used:         2
+
----------------
A lot of these prefixes look redundant?


Repository:
  rL LLVM

https://reviews.llvm.org/D48190