[PATCH] D47922: unsigned foo(unsigned x, unsigned y) { return x > y && x != 0; } should fold to x > y

Li Jia He via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 15 00:21:15 PDT 2018


HLJ2009 added a comment.

In https://reviews.llvm.org/D47922#1133217, @lebedev.ri wrote:

> Ok, thanks, that is much better.
>  Alive agrees that these are valid transforms.
>  I would personally prefer to also have some *negative* tests.
>  But this looks good to me. Unless others have any comments.


Thank you very much for the code reviewer, and also thanks for introducing the use of the update_test_checks.py tool.


Repository:
  rL LLVM

https://reviews.llvm.org/D47922





More information about the llvm-commits mailing list