[PATCH] D48201: [cmake] Add linker detection for Apple platforms

Saleem Abdulrasool via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 14 16:09:30 PDT 2018


compnerd accepted this revision.
compnerd added a comment.
This revision is now accepted and ready to land.

It really is unfortunate that linkers can spell version differently :-(.  It would be really nice to be able to unify the linker version detection.



================
Comment at: llvm/cmake/modules/AddLLVM.cmake:157
+  if("${stderr}" MATCHES "PROJECT:ld64")
+    set(LLVM_LINKER_IS_LD64 ON)
+    message(STATUS "Linker detection: ld64")
----------------
`YES` is better than `ON` here IMO


Repository:
  rL LLVM

https://reviews.llvm.org/D48201





More information about the llvm-commits mailing list