[PATCH] D48198: AMDGPU/GlobalISel: Default to using TableGen'd instruction selector

Tom Stellard via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 14 14:28:43 PDT 2018


tstellar created this revision.
tstellar added reviewers: arsenm, nhaehnle.
Herald added subscribers: t-tye, tpr, dstuttard, kristof.beyls, rovka, yaxunl, wdng, kzhuravl.

We can select all instructions that are marked as legal in a full piglit run,
so now is a good time to make the TableGen'd instruction selector default
for all opcodes.  This is NFC for a full piglit run, which is why there are
no tests.


Repository:
  rL LLVM

https://reviews.llvm.org/D48198

Files:
  lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp


Index: lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp
===================================================================
--- lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp
+++ lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp
@@ -605,13 +605,6 @@
 
   switch (I.getOpcode()) {
   default:
-    break;
-  case TargetOpcode::G_ASHR:
-  case TargetOpcode::G_SITOFP:
-  case TargetOpcode::G_FMUL:
-  case TargetOpcode::G_FADD:
-  case TargetOpcode::G_FPTOUI:
-  case TargetOpcode::G_OR:
     return selectImpl(I, CoverageInfo);
   case TargetOpcode::G_ADD:
     return selectG_ADD(I);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D48198.151426.patch
Type: text/x-patch
Size: 582 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180614/b7e5fbbb/attachment.bin>


More information about the llvm-commits mailing list