[PATCH] D48189: [llvm] Document "%T" as deprecated in TestingGuide.rst

Peter Wu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 14 13:12:52 PDT 2018


Lekensteyn added a comment.

One small comment, LGTM otherwise.



================
Comment at: docs/TestingGuide.rst:464
+   Directory of ``%t``. Deprecated. Shouldn't be used, because it can be easily
+   misused and cause race conditions between tests. 
 
----------------
What about suggesting an alternative like:

    Use ``rm -rf %t && mkdir %t`` instead if a temporary directory is necessary.

Perhaps that could even replace the `Shouldn't be used, because [reason]` sentence if brevity is desired.


https://reviews.llvm.org/D48189





More information about the llvm-commits mailing list