[PATCH] D48164: [llvm-exegesis] Print the whole snippet in analysis.

Clement Courbet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 14 09:11:11 PDT 2018


courbet added inline comments.


================
Comment at: tools/llvm-exegesis/lib/Analysis.cpp:94
+                            const char *Separator) const {
+  llvm::SmallVector<std::string, 3> Lines;
+  // Parse the asm snippet and print it.
----------------
gchatelet wrote:
> Why not a `llvm::SmallVector<llvm::SmallString<16>, 3>` ?
llvm::join is not nicely compatible with SmallString.


Repository:
  rL LLVM

https://reviews.llvm.org/D48164





More information about the llvm-commits mailing list