[PATCH] D48067: [InstCombine] Replacing X86-specific rounding intrinsics with generic floor-ceil

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 14 07:42:17 PDT 2018


craig.topper added a comment.

Yes an non-constant value will fail isel and print a readable error message. But if you assume constant in instcombine by just using “cast” and it’s not we’ll get a segmentation fault in release builds before we get to isel. This is a much worse experience for users. So I suggest just ignoring any intrinsics with non-constant here and let isel throw an error.


https://reviews.llvm.org/D48067





More information about the llvm-commits mailing list