[PATCH] D47755: [RISCV] Insert R_RISCV_ALIGN relocation type and Nops for alignment when linker relaxation enabled

[Alex Bradbury via Phabricator via llvm-commits]

asb added a comment.
Herald added a subscriber: rogfer01.

Hi Shiva. I think your tests need to demonstrate the behaviour when there is no C extension support as well.



================
Comment at: lib/Target/RISCV/MCTargetDesc/RISCVAsmBackend.cpp:61-66
+  bool insertNopBytesForAlignDirectiveInTextSection(const MCFragment &F,
+                                                    unsigned &Size) override;
+
+  bool insertFixupForAlignDirectiveInTextSection(MCAssembler &Asm,
+                                                 const MCAsmLayout &Layout,
+                                                 MCFragment &F) override;
----------------
Given that the implementations of these always cast to MCAlignFragment, why not take an MCAlignFragment instead of MCFragment?


Repository:
  rL LLVM

https://reviews.llvm.org/D47755