[PATCH] D48128: [ARM] Parallel DSP IR Pass

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer marked 6 inline comments as done.
SjoerdMeijer added inline comments.


================
Comment at: lib/Transforms/Scalar/ParallelDSP.cpp:357
+
+static bool MatchReductions(Function &F, Loop *TheLoop, BasicBlock *Header,
+                            ReductionList &Reductions) {
----------------
samparker wrote:
> This interface could be simplified by passing HasFnNoNanAttr instead of the function. Similarly, I don't see why its necessary to pass the loop and its header.
The Header is used to iterator over its Phi's, and the loop to get its latch blocks. HasFnNoNanAttr is used only here, and hoisting it out and passing it looks a bit clumsy to me. Thus I think the interface and passing the function, loop, and header, is covering it quite well.


https://reviews.llvm.org/D48128