[PATCH] D47857: [RISCV] Add machine function pass to merge base + offset

[Alex Bradbury via Phabricator via llvm-commits]

asb accepted this revision.
asb added a comment.
This revision is now accepted and ready to land.

Thanks, this looks good to me assuming the minor nits are addressed. The only one requiring code changes is the for loop in matchLargeOffset.



================
Comment at: lib/Target/RISCV/RISCVMergeBaseOffset.cpp:25
+//===----------------------------------------------------------------------===//
+
+#include "RISCV.h"
----------------
There are a few miscellaneous minor formatting issues in this file that will be fixed with clang-format


================
Comment at: lib/Target/RISCV/RISCVMergeBaseOffset.cpp:28-38
+#include "RISCVTargetObjectFile.h"
+#include "llvm/ADT/STLExtras.h"
+#include "llvm/CodeGen/Passes.h"
+#include "llvm/CodeGen/TargetLoweringObjectFileImpl.h"
+#include "llvm/CodeGen/TargetPassConfig.h"
+#include "llvm/IR/LegacyPassManager.h"
+#include "llvm/Support/Debug.h"
----------------
A number of these includes seem totally unused. e.g. STLExtras., RISCVTargetObjctFile.h, TargetLoweringObjectFileIMpl.h


https://reviews.llvm.org/D47857