[PATCH] D48052: [sanitizer] Don't treat colon before slash as a flag separator

Vitaly Buka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 13 16:39:27 PDT 2018


vitalybuka added inline comments.


================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_flag_parser.cc:77
+  // path separator. This avoids common portability issues when an unquoted
+  // Windows path is used, as in 'symbolizer_path=C:/foo/llvm-symbolizer.exe'.
+  // Since no option names should start with / or \, it should be unambiguous.
----------------
All these variables are mapped to the same C++ members. So not sure if it's worth it but what if we generalize to:
":" is separateor IFF it's followed by "[a-zA_Z0-9_]+="



https://reviews.llvm.org/D48052





More information about the llvm-commits mailing list