[PATCH] D48080: [VPlanRecipeBase] Add insertBefore helper.
Diego Caballero via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 13 15:59:38 PDT 2018
dcaballe accepted this revision.
dcaballe added a comment.
This revision is now accepted and ready to land.
Thanks for the patch! LGTM.
I think it's ok to kept these utilities in the VPRecipeBase class for now. Eventually, if we add too many, we may want to move them to a VPInstructionUtils, same as what we are doing for VPBlockBase.
================
Comment at: lib/Transforms/Vectorize/VPlan.h:560
+
+ /// Insert an unlinked instruction into a basic block immediately before
+ /// the specified instruction.
----------------
instruction -> recipe?
https://reviews.llvm.org/D48080
More information about the llvm-commits
mailing list