[PATCH] D48149: Expand constrained FP POWI
Cameron McInally via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 13 14:28:44 PDT 2018
cameron.mcinally added inline comments.
================
Comment at: lib/CodeGen/SelectionDAG/LegalizeVectorOps.cpp:729
return ExpandCTTZ_ZERO_UNDEF(Op);
case ISD::STRICT_FSQRT:
case ISD::STRICT_FMA:
----------------
cameron.mcinally wrote:
> craig.topper wrote:
> > Should STRICT_FMUL/DIV/ADD/SUB be here even though I don't know how to test them? If some target did it someday, we would end up the default case which would do the wrong thing.
> Ah, you're right. That's a typo.
>
> There could definitely be a RISC-like target without vector arith ops.
These are also missing from SelectionDAGLegalize::LegalizeOp(...). I'll roll that change into this one, if there are no objections.
Repository:
rL LLVM
https://reviews.llvm.org/D48149
More information about the llvm-commits
mailing list