[PATCH] D47895: llvm: Add support for "-fno-delete-null-pointer-checks"

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: lib/Transforms/IPO/GlobalOpt.cpp:1931
       GV->getValueType()->isSingleValueType() &&
       GV->getType()->getAddressSpace() == 0 &&
       !GV->isExternallyInitialized() &&
----------------
manojgupta wrote:
> This pass already skips non-zero address space values. I didn't want to bail out here since all of the accesses to a GV might be in functions without null-pointer-is-valid attribute.
Fine; please add a comment to AllUsesOfValueWillTrapIfNull.


Repository:
  rL LLVM

https://reviews.llvm.org/D47895