[PATCH] D48135: [DWARFv5] Tolerate files not all having an MD5 checksum.

Jonas Devlieghere via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 13 11:27:47 PDT 2018


JDevlieghere added inline comments.


================
Comment at: llvm/include/llvm/MC/MCDwarf.h:255
     Header.RootFile.Source = Source;
-    Header.HasMD5 = (Checksum != nullptr);
+    Header.HasAnyMD5 |= bool(Checksum);
+    Header.HasAllMD5 &= bool(Checksum);
----------------
How do you feel about a convenience method that takes the header and checksum pointer and updates both?


https://reviews.llvm.org/D48135





More information about the llvm-commits mailing list