[compiler-rt] r334558 - [ASAN] disable fgets_fputs test for android and darwin

[Ahmed Bougacha via llvm-commits]

Hi Peter,

I re-enabled this for darwin in r334626.

It seems to be passing, triggering a bunch of XPASS failures on the
bots I've seen, e.g.:
http://green.lab.llvm.org/green/job/clang-stage1-configure-RA/46106/consoleFull#-380363384bb79bcff-293f-4a8e-8a8b-980d8b553ee8

Which bots show a darwin failure?  If that still happens, you can mark
the test as UNSUPPORTED while you investigate.
-Ahmed


On Tue, Jun 12, 2018 at 4:05 PM, Peter Wu via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> Author: lekensteyn
> Date: Tue Jun 12 16:05:03 2018
> New Revision: 334558
>
> URL: http://llvm.org/viewvc/llvm-project?rev=334558&view=rev
> Log:
> [ASAN] disable fgets_fputs test for android and darwin
>
> aarch64/aosp_marlin-userdebug/OPR4.170623.016] builder unexpectedly
> failed the fgets test (`assertion "fp" failed`). macOS unexpectedly
> passes the fputs test without triggering ASAN.
>
> Modified:
>     compiler-rt/trunk/test/asan/TestCases/Posix/fgets_fputs.cc
>
> Modified: compiler-rt/trunk/test/asan/TestCases/Posix/fgets_fputs.cc
> URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/asan/TestCases/Posix/fgets_fputs.cc?rev=334558&r1=334557&r2=334558&view=diff
> ==============================================================================
> --- compiler-rt/trunk/test/asan/TestCases/Posix/fgets_fputs.cc (original)
> +++ compiler-rt/trunk/test/asan/TestCases/Posix/fgets_fputs.cc Tue Jun 12 16:05:03 2018
> @@ -3,6 +3,7 @@
>  // RUN: not %run %t 1 %t-testdata 2>&1 | FileCheck %s --check-prefix=CHECK-FGETS
>  // RUN: not %run %t 2 2>&1 | FileCheck %s --check-prefix=CHECK-FPUTS
>  // RUN: not %run %t 3 2>&1 | FileCheck %s --check-prefix=CHECK-PUTS
> +// XFAIL: android, darwin
>
>  #include <assert.h>
>  #include <stdio.h>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits