[PATCH] D48112: Simplify PPC64::calcEFlags().

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: lld/ELF/Arch/PPC64.cpp:121
+    if (Flag != 0 && Flag != 2)
+      error(toString(F) + ": ABI version " + Twine(Flag) + " is not supported");
   }
----------------
sfertile wrote:
> I think we should still emit 2 separate error messages:
> 
> 1) if flags & 1 is set then emit an error message that reflects we don't support the V1 abi.
> 2) if any flags bits other then bits 1 or 2 are set then we emit a message for unrecognized e_flags.
What do you suggest for the second message? I thought it would be something like "unsupported ABI version: 3" which is basically the same error message for v1.


https://reviews.llvm.org/D48112