[PATCH] D48109: [Timers] Use the pass argument name for JSON keys in time-passes

Jessica Paquette via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 13 09:44:27 PDT 2018


paquette added a comment.

This would make much more sense IMO. Especially for passes with long names. (For example, I'd much rather see "patchable-function" than "Implement the 'patchable-function' attribute" in the JSON)

In https://reviews.llvm.org/D48109#1130700, @lebedev.ri wrote:

> I guess this makes sense.
>  But what about new pass manager?


A quick grep shows that `Timer`s are currently only used in the legacy PM.

Is timing info implemented in the new PM yet? If not, I think it would make sense to just move forward with this; the change is pretty simple, and I can't really see it blocking or increasing the work that'd have to go into a new PM implementation.

Other than the new PM question, this LGTM.


https://reviews.llvm.org/D48109





More information about the llvm-commits mailing list