[PATCH] D48097: [TSan] Fix madvise(MADV_NOHUGEPAGE) for meta shadow memory

[Aleksey Shlyapnikov via Phabricator via llvm-commits]

alekseyshl added a comment.

Thanks!



================
Comment at: lib/tsan/rtl/tsan_platform_posix.cc:33
+      Printf(kShadowMemoryMappingWarning, SanitizerToolName, addr, addr + size,
+             "MADV_NOHUGEPAGE");
+      Die();
----------------
By the way, do you think we should hint on the flag name controlling this feature here (like "set no_huge_pages_for_shadow=0 if it does not work for you") or we'd rather hear about the problem? I think the latter is preferred. The same for MADV_DONTDUMP below.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D48097