[PATCH] D48020: [llvm-exegesis] Cleaner design without mutable data.

[Clement Courbet via Phabricator via llvm-commits]

courbet added inline comments.


================
Comment at: tools/llvm-exegesis/lib/Latency.cpp:58
+  const AliasingConfigurations SelfAliasing(Instr, Instr);
+  if (SelfAliasing.empty()) {
+    // No self aliasing, trying to create a dependency through another opcode.
----------------
what about splitting the if in two subfunctions ?


================
Comment at: tools/llvm-exegesis/lib/Uops.cpp:92
 
-static bool isInfeasible(const Instruction &Instruction, std::string &Error) {
-  const auto &MCInstrDesc = Instruction.Description;
-  if (MCInstrDesc.isPseudo()) {
-    Error = "is pseudo";
-    return true;
-  }
-  if (llvm::any_of(MCInstrDesc.operands(), hasUnknownOperand)) {
-    Error = "has unknown operands";
-    return true;
-  }
-  if (llvm::any_of(MCInstrDesc.operands(), hasMemoryOperand)) {
-    Error = "has memory operands";
-    return true;
-  }
-  return false;
+// static bool isInfeasible(const Instr &Instr, std::string &Error)
+// {
----------------
rm this


Repository:
  rL LLVM

https://reviews.llvm.org/D48020