[PATCH] D48115: Make ThreadPool support running tasks that return values

Pavel Labath via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 13 00:31:14 PDT 2018


labath accepted this revision.
labath added a comment.

looks good



================
Comment at: llvm/include/llvm/Support/ThreadPool.h:30
 
+#include <assert.h>
+
----------------
you could include `cassert` so it fits in nicely with the other c++ headers.


================
Comment at: llvm/include/llvm/Support/ThreadPool.h:55-56
 public:
   using TaskTy = std::function<void()>;
   using PackagedTaskTy = std::packaged_task<void()>;
 
----------------
Are these still needed/used ?


https://reviews.llvm.org/D48115





More information about the llvm-commits mailing list