[PATCH] D47675: [test-suite][RFC] Using Google Benchmark Library on Harris Kernel

[Pankaj via Phabricator via llvm-commits]

proton added a comment.

In https://reviews.llvm.org/D47675#1129087, @Meinersbur wrote:

> Looks great. Did you do a performance comparison with/without Polly?


polly + https://reviews.llvm.org/owners/package/3/ and only https://reviews.llvm.org/owners/package/3/ are taking the same time. It seems like before code reaches Polly, It is already heavily optimized at https://reviews.llvm.org/owners/package/3/ and Polly cannot find any further optimization possible on it even though it is in its SCoP.

> [suggestion] Even though Google Benchmark by default does not run kernels in multiple threads, it might be a good idea to prepare for it. That is, no global shared `img` array.

Updated.
I still have to keep an extra global array (other than the image) to copy the final output to. I couldn't modify the original image array as it will affect the input of other threads.

> [comment] Is there are a reason why the `init.cpp` and `main.cpp` are separate files?

`init.cpp` have image initialization and print function which can be used on other image processing kernels as well, So I kept it in a separate file so that It can be used as it is on different kernels as well.


https://reviews.llvm.org/D47675