[PATCH] D48097: [TSan] Fix madvise(MADV_NOHUGEPAGE) for meta shadow memory

[Dmitry Vyukov via Phabricator via llvm-commits]

dvyukov added inline comments.


================
Comment at: lib/tsan/rtl/tsan_platform_posix.cc:32
+    if (!NoHugePagesInRegion(addr, size))
+      Printf(kShadowMemoryMappingWarning, SanitizerToolName, addr, addr + size,
+             "MADV_NOHUGEPAGE");
----------------
If we want to notice this in future we need to Die.
We never print anything unless there is a bug in program, or we terminate the program. Altered output breaks programs in surprising ways (consider altering output of protoc). Also if this happened in chrome or in our server code base all the time, we will never notice a warning line in output and nobody will notify us.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D48097