[PATCH] D47949: [callsitesplit] Limit the # of predecessors walk when recording condition

[Xin Tong via Phabricator via llvm-commits]

trentxintong added a comment.

@davide @fhahn I am sorry that I cant provide the source code. But one of the cases that resulted in chasing up the chain a lot I can see came from a sequence of object declarations & initializations (constructors which can throw). And they cascaded into a block with 2 predecessors.

Actually in this case we did not manage to find anything interesting to arguments, i.e. the terminator is an InvokeInst.

Before we fix the pass, do you think its reasonable to land this patch (with test cases provided) and a FIXME on the knob about this discussion/review so that we can remove it after the fundamental problem with the pass is addressed to help us and also possibly other people with similar situations.


Repository:
  rL LLVM

https://reviews.llvm.org/D47949