[PATCH] D48058: Handle R_X86_64_GOTOFF64.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 12 12:53:13 PDT 2018


ruiu added a comment.

It is not me who requested you remove GOTOFF64 relocation support from your patch, but if you have a patch with a title "Add R_X86_64_GOTPC{32,64} support", I wouldn't be surprised if you are requested to remove code to support other types of relocations, as patches shouldn't contain unrelated changes. A best practice is to separate a patch to two or more.


https://reviews.llvm.org/D48058





More information about the llvm-commits mailing list