[PATCH] D47098: [ELF] Support R_X86_64_GOTPC{32,64}

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

I applied this patch but the test failed. Can you fix?



================
Comment at: ELF/Relocations.cpp:350
                      R_MIPS_GOT_GP_PC, R_MIPS_TLSGD, R_GOT_PAGE_PC, R_GOT_PC,
-                     R_GOTONLY_PC, R_GOTONLY_PC_FROM_END, R_PLT_PC, R_TLSGD_GOT,
+                     R_GOTONLY_PC, R_GOTONLY_PC_FROM_END, R_GOTREL_FROM_END, R_PLT_PC, R_TLSGD_GOT,
                      R_TLSGD_PC, R_TLSGD, R_PPC_CALL_PLT, R_TLSDESC_CALL,
----------------
clang-format


================
Comment at: test/ELF/x86-64-reloc-got.s:11
+// 0x3070 (.got end) - 0x1007 = 8297
+// CHECK: R_X86_64_GOTPC32:
+// CHECK-NEXT: 1000: {{.*}} leaq 8297(%rip), %r15
----------------
Let's avoid using the exact same name for both relocation type and function name. That's very confusing to humans when reading disassembly. Just fn1 and fn2 should suffice.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D47098